-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove (possible) infinite loop from CmdLogin. #395
Conversation
I believe this also addresses the reported issue: #345 |
yeah! this looks great! please add me as a reviewer and I will approve |
Any reason this isn't merged? |
Not really, just lost touch of the project. I'll take a second look and merge when done |
Tested this one locally and appears to work correctly, and resolves loop as I saw it as well. |
seems I don't have the power yet to approve (although I am in the list?) |
🤞 |
Got a response from @mikepea https://twitter.com/mikepea/status/1463942769097904128 though it seems he might not be comfortable approving new maitainers because he's not been involved for a while. |
Might be worth mentioning here that I was added to some extent as a maintainer |
@mikepea if you get a chance this week could you see if this one can be merged too? |
Couldn't determine original intention of loop within
CmdLogin
, but ran into an issue locally where a cron job that ran the login command inadvertently got stuck in a failure loop where it continued to make bad requests to the Jira server.